Skip to content

Conversation

@mabela416
Copy link
Contributor

The build continues to fail because of color-contrast failures in the accessibility check for the ButtonReact.cy.tsx test. I thought I had fixed it but it seems to continue to happen although I can't reproduce it locally anymore. I think maybe the CI got into a weird state since I merged this PR for the sparkle icon with test failures and then merged the fix after.

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: 26f431c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
cypress-design Ready Ready Preview Oct 14, 2025 7:05pm

@mabela416 mabela416 self-assigned this Oct 14, 2025
@cypress
Copy link

cypress bot commented Oct 14, 2025

cypress-design    Run #3227

Run Properties:  status check passed Passed #3227  •  git commit 3bcd90a2a5 ℹ️: Merge 26f431ccf43299bed507abe5d66b9934e6be42a7 into b34d23ca4f53291d3140ee17037e...
Project cypress-design
Branch Review mabel/turn-off-color-constant-check
Run status status check passed Passed #3227
Run duration 02m 08s
Commit git commit 3bcd90a2a5 ℹ️: Merge 26f431ccf43299bed507abe5d66b9934e6be42a7 into b34d23ca4f53291d3140ee17037e...
Committer mabela416
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 4  
  Tested elements 0  
Accessibility  88.41%
  Failed rules  1 critical   0 serious   3 moderate   0 minor
  Failed elements 4  

@mabela416 mabela416 merged commit ce73822 into main Oct 14, 2025
84 of 94 checks passed
@mabela416 mabela416 deleted the mabel/turn-off-color-constant-check branch October 14, 2025 20:26
@cypress
Copy link

cypress bot commented Oct 14, 2025

cypress-design    Run #3230

Run Properties:  status check passed Passed #3230  •  git commit ce738227b9: temporarily turn off color contrast accessibility check (#626)
Project cypress-design
Branch Review main
Run status status check passed Passed #3230
Run duration 02m 08s
Commit git commit ce738227b9: temporarily turn off color contrast accessibility check (#626)
Committer mabela416
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 9  
  Tested elements 0  
Accessibility  94.24%
  Failed rules  0 critical   1 serious   3 moderate   0 minor
  Failed elements 8  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants